Skip to content

feat: add math/base/special/acschf#10159

Open
whizzel wants to merge 12 commits intostdlib-js:developfrom
whizzel:acschf
Open

feat: add math/base/special/acschf#10159
whizzel wants to merge 12 commits intostdlib-js:developfrom
whizzel:acschf

Conversation

@whizzel
Copy link
Copy Markdown
Contributor

@whizzel whizzel commented Feb 8, 2026 •
edited
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Ref: #649 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds the complete implementation for math/base/special/acschf .

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@whizzel
feat: add math/base/special/acschf
b67e47b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 8, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 8, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/acschf $\color{green}163/163$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}163/163$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@whizzel
refactor: update acschf native tests to use isAlmostSameValue
4a9b083 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel
bench: refactor to use string interpolation in bechmark
086fcda 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel
chore: trigger CI
21c78eb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel
bench: refactor to use string interpolation in bechmark
9a42555 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel
Copy link
Copy Markdown
Contributor Author

whizzel commented Feb 11, 2026

@Planeshifter review plz!

@whizzel whizzel changed the title feat: add math/base/special/acschf feat: add math/base/special/acschf Feb 12, 2026
Planeshifter
Planeshifter requested changes Feb 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked until fixture generation is resolved.

Comment thread lib/node_modules/@stdlib/math/base/special/acschf/README.md Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/README.md Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/README.md Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.native.js
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/fixtures/julia/runner.jl Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/README.md Outdated
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 14, 2026
whizzel and others added 2 commits February 14, 2026 13:14
@whizzel
Merge branch 'stdlib-js:develop' into acschf
e9936e5
@whizzel
chore: changes according review
3ee1eff 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel whizzel requested a review from Planeshifter February 14, 2026 09:25
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 14, 2026
@whizzel
Copy link
Copy Markdown
Contributor Author

whizzel commented Feb 14, 2026

okey, acsch is Julia's built-in inverse hyperbolic cosecant function so i changed acschf to acsch. is this okey??
and also needs review on whole acschf/test/fixtures/julia/runner.jl. @Planeshifter

Planeshifter
Planeshifter requested changes Feb 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.native.js Outdated
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Feb 24, 2026
@whizzel
chore: changes according to code review
c8b533f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel whizzel requested a review from Planeshifter February 24, 2026 12:49
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 24, 2026
Planeshifter
Planeshifter requested changes Mar 4, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/README.md Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/README.md Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/examples/c/example.c Outdated
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 4, 2026
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Mar 4, 2026
@stdlib-js stdlib-js deleted a comment from stdlib-bot Mar 4, 2026
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 4, 2026
@whizzel
chore: changes according to review
2ab8d2f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel whizzel requested a review from Planeshifter March 4, 2026 02:04
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 4, 2026
@whizzel
feat: improve tests and Julia fixture generation
ddec403 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel
Copy link
Copy Markdown
Contributor Author

whizzel commented Mar 9, 2026

@Planeshifter a quick review here too

Planeshifter
Planeshifter requested changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another round of feedback.

Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/acschf/benchmark/benchmark.native.js Outdated
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 10, 2026
@whizzel
fix: ensure acschf consistency with acsch package
c014264 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@whizzel
Copy link
Copy Markdown
Contributor Author

whizzel commented Mar 10, 2026 •
edited
Loading

@Planeshifter Both suggestions refer to an outdated commit. The changes have already been addressed in a later commit. Could you please review the latest commit or the updated code?

@whizzel whizzel requested a review from Planeshifter March 10, 2026 19:09
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 10, 2026
@whizzel
Copy link
Copy Markdown
Contributor Author

whizzel commented Mar 15, 2026

@Planeshifter Just checking — is this PR ready to land? I’m preparing my GSoC proposal and wanted to ready.

Copilot AI review requested due to automatic review settings April 9, 2026 11:58
Copilot AI reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot mentioned this pull request Apr 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@whizzel @stdlib-bot @Planeshifter